cody: update indexing icons #54262
Merged
cody: update indexing icons #54262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the styles based on the Figma, and testing in VS Code. While I was there, my brain was breaking trying to redo the icons and styles with all the variables and structs, so I redid things to be a little more imperative in JSX so I could more easily track what's going on. |
toolmantim
approved these changes
Jun 27, 2023
| ) : contextStatus.mode && contextStatus.connection ? ( | ||
| <CodebaseState | ||
| codebase={contextStatus.codebase} | ||
| tooltip="Repository is indexed and has embeddings" |
There was a problem hiding this comment.
I opted to keep the word "embeddings" in here for the SG Enterprise customers. Code Search hasn't caught up with the term "Indexed" as far as Cody goes yet, so including it will help for search, docs and the site admin.
|
Updated to use warning color for non-indexed repo to aligns with dotcom: |
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close sourcegraph/cody#86
Update codebase status icons based on tim's figma design.
Test plan
when codebase is indexed
when codebase is not indexed
when codebase is not indexed and not a valid git repository
