Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Fix error handling in chat messages #54268

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

philipp-spiess
Copy link
Contributor

Closes #54256

Fix error handling when the client <> server connection is closed when sending chat messages.

Test plan

Screen.Recording.2023-06-27.at.11.39.11.mov

@philipp-spiess philipp-spiess requested review from toolmantim, abeatrix and a team June 27, 2023 09:41
@philipp-spiess philipp-spiess self-assigned this Jun 27, 2023
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jun 27, 2023
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

@@ -729,6 +733,7 @@ export class ChatViewProvider implements vscode.WebviewViewProvider, vscode.Disp
* Send embedding connections or results error to output
*/
private logEmbeddingsSearchErrors(): void {
console.log(this.int)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(this.int)

left over?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha you are too fast, already removed it :)

@philipp-spiess philipp-spiess enabled auto-merge (squash) June 27, 2023 09:47
@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@philipp-spiess philipp-spiess merged commit 0f67424 into main Jun 27, 2023
11 of 13 checks passed
@philipp-spiess philipp-spiess deleted the ps/cody-fix-error-handling-in-chat-messages branch June 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody: Chat thread error does not complete the request
3 participants