Cody: Do not flicker error messages when aborting during context fetching #54429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team/code-exploration
|
@philipp-spiess Opened a issue here which you can link for this #54427 |
|
@deepak2431 machine! thank you :) How do you stay in touch with all the changes? Are you subscribed to the repo? 😱 |
|
@philipp-spiess You're welcome :) |
abeatrix
approved these changes
Jun 29, 2023
we test in prod 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54427
During context fetching if we abort the request before we ever got a response from the server, we get a message with the text
socket hang upin addition to theabortederror when responses are always streaming in.With the recent changes from me to properly bubble up context fetching errors, these messages became visible in some unintended ways:
This PR fixes the issue by handling both
abortandsocket hang upmessages.Test plan