Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cody Inline Chat: Add "Collapse All Comments" #54675

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Cody Inline Chat: Add "Collapse All Comments" #54675

merged 3 commits into from
Jul 7, 2023

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Jul 6, 2023

CodyInlineCollapse.mp4

Adds a "Collapse All Comments" option to the inline chat header

Test plan

Tested locally in VS Code.

@cla-bot cla-bot bot added the cla-signed label Jul 6, 2023
@umpox umpox requested review from a team July 6, 2023 13:15
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jul 6, 2023
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jul 6, 2023 •
edited

📖 Storybook live preview

@umpox umpox changed the title Cody Inline Chat: Add "Collapse All Comments" Cody Inline Chat: Add "Collapse All Chats" Jul 6, 2023
@umpox umpox changed the title Cody Inline Chat: Add "Collapse All Chats" Cody Inline Chat: Add "Collapse All Comments" Jul 6, 2023
@umpox
Copy link
Contributor Author

umpox commented Jul 6, 2023

Unsure if this should be called "Collapse All Chats', but we refer to them as comments in other places (e.g. "Delete comment") and they are technically VS Code comments

valerybugakov
valerybugakov approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@valerybugakov valerybugakov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is called "inline chat", and we have commands using this name (e.g., Show Inline Chat). Would naming this command "Collapse all Inline Chats" make sense?

UPD: I didn't see your comment above initially 😛

@umpox
Copy link
Contributor Author

umpox commented Jul 7, 2023

@valerybugakov Yeah wasn't too sure. After looking further it seems VS Code doesn't reference these as comments too much (only named as such in a panel next to the terminal AFAICT). We only refer to them as comments in one other place so have updated to "Inline Chats"

@umpox umpox enabled auto-merge (squash) July 7, 2023 07:34
@umpox umpox disabled auto-merge July 7, 2023 07:34
@umpox umpox enabled auto-merge (squash) July 7, 2023 07:36
@umpox umpox merged commit b040b5d into main Jul 7, 2023
9 of 11 checks passed
@umpox umpox deleted the tr/cody-collapse-all branch July 7, 2023 07:46
nelsonjr pushed a commit that referenced this pull request Jul 11, 2023
@umpox @nelsonjr
Cody Inline Chat: Add "Collapse All Comments" (#54675)
b0b761e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valerybugakov valerybugakov valerybugakov approved these changes

Assignees
No one assigned
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umpox @sourcegraph-bot @valerybugakov