blob: Always select search input value when pressing Mod-f #55546
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkling
added
team/code-search
Browers' built-in search input will select the input value when pressing Mod-f, even when the focus is already on the search input. The default CodeMirror behavior will only select the input value when the input is not already focused. This PR changes the behavior to match the browser's behavior.
fkling
force-pushed
the
fkling/54810-file-search-select
branch
from
be44f60
to
9a3c8c5
Compare
coury-clark
approved these changes
Aug 3, 2023
davejrt
pushed a commit
that referenced
this pull request
Aug 9, 2023
Resolves #54810 Browsers' built-in search input will select the input value when pressing Mod-f, even when the focus is already on the search input. The default CodeMirror behavior will only select the input value when the input is not already focused. This PR changes the behavior to match the browser's behavior. ## Test plan - Open file page - Press `Mod-f` to open file search - Type any input value - Press `Mod-f` again -> input value is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54810
Browsers' built-in search input will select the input value when pressing Mod-f, even when the focus is already on the search input.
The default CodeMirror behavior will only select the input value when the input is not already focused. This PR changes the behavior to match the browser's behavior.
Test plan
Mod-fto open file searchMod-fagain -> input value is selected