hide access token by default after creation #56481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
changed the title
unknwon
approved these changes
Sep 8, 2023
|
Just realized even though the token is hidden, it's still contained in the |
|
is that token from the screenshot for localhost? 😬 |
|
Lmaooo. Yes it’s for my local environment.
That’s why I didn’t bother removing it.
I already revoked it on my machine also incase of any magic.
…On Sat, Sep 9, 2023 at 00:33 Erik Seliger ***@***.***> wrote:
is that token from the screenshot for localhost? 😬
—
Reply to this email directly, view it on GitHub
<#56481 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGDMBDYJKSF6OQ3DFR3YH6TXZOTNXANCNFSM6AAAAAA4Q7HF74>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
eseliger
approved these changes
Sep 11, 2023
BolajiOlajide
force-pushed
the
bo/display-access-token-as-secret
branch
from
80fb55d
to
9744f32
Compare
stefanhengl
pushed a commit
that referenced
this pull request
Sep 13, 2023
[Context](https://sourcegraph.slack.com/archives/C04MSD3DP5L/p1694188323196199) When a user creates an access token on Sourcegraph, we currently display the token by default in plain text. Sometimes the user is in a public place and this token could be captured by an attacker and used for malicious purposes. This PR hides the token by default and the user can then click to see it or simply just copy it for use.  ## Test plan * I manually went through the flow of creating an access token by visiting my profile page [`/users/<USER>/settings/tokens`](https://sourcegraph.sourcegraph.com/users/bolaji.olajide-tkzij/settings/tokens) * Then clicking on the `Generate new token` button * This should display the newly created access token with the token hidden by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a user creates an access token on Sourcegraph, we currently display the token by default in plain text. Sometimes the user is in a public place and this token could be captured by an attacker and used for malicious purposes.
This PR hides the token by default and the user can then click to see it or simply just copy it for use.
Test plan
/users/<USER>/settings/tokensGenerate new tokenbutton