Remove unused rateLimit on perforce connections #58188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perforce doesn't actually use any HTTP APIs so the regular rate limiting logic would never catch anything here. To avoid confusion, we've decided to remove it. If in the future we get requests for rate limiting, we can implement it again, but the on a gitserver level or so.
github-actions
bot
added
the
team/source
eseliger
commented
Nov 8, 2023
|
@sourcegraph/source ping :) |
mrnugget
approved these changes
Nov 14, 2023
pjlast
approved these changes
Nov 14, 2023
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
Perforce doesn't actually use any HTTP APIs so the regular rate limiting logic would never catch anything here. To avoid confusion, we've decided to remove it. If in the future we get requests for rate limiting, we can implement it again, but the on a gitserver level or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perforce doesn't actually use any HTTP APIs so the regular rate limiting logic would never catch anything here. To avoid confusion, we've decided to remove it.
If in the future we get requests for rate limiting, we can implement it again, but the on a gitserver level or so.
Test plan
CI.