[Backport 5.3.9104] streaming: only call flush if writes succeeded #61756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a speculative change to reduce the chances of misuse of the streaming http event writer (SSE). We are seeing panics in attribution search since it is trying to write events once the request has finished. From the stack traces it seems the http package safely handles calls to Write without panicing but does not do the same for Flush. This change also seems more correct. Note: this does not address the root cause of the panics, but should make it far less likely to occur. Test Plan: go test (cherry picked from commit 1d07a27)
sourcegraph-release-bot
added
team/search-platform
keegancsmith
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative change to reduce the chances of misuse of the streaming http event writer (SSE). We are seeing panics in attribution search since it is trying to write events once the request has finished.
From the stack traces it seems the http package safely handles calls to Write without panicing but does not do the same for Flush. This change also seems more correct.
Note: this does not address the root cause of the panics, but should make it far less likely to occur.
Test Plan: go test
Part of #60439
Backport 1d07a27 from #61752