monitoring: fix "instance" dropdown for Zoekt #61836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index_num_assigned metric no longer exists. This should fix a few all the graphs that you are able to select which indexserver to look at. Test Plan:
github-actions
bot
added
team/product-platform
team/search-platform
mmanela
approved these changes
Apr 12, 2024
sourcegraph-release-guild-bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
The index_num_assigned metric no longer exists. This should fix a few all the graphs that you are able to select which indexserver to look at. Test Plan: (cherry picked from commit 2fef038)
keegancsmith
added a commit
that referenced
this pull request
Apr 19, 2024
…2042) monitoring: fix "instance" dropdown for Zoekt (#61836) The index_num_assigned metric no longer exists. This should fix a few all the graphs that you are able to select which indexserver to look at. Test Plan: (cherry picked from commit 2fef038) Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index_num_assigned metric no longer exists. This should fix a few all the graphs that you are able to select which indexserver to look at.
Test Plan: tested this metric had the requisite fields via dotcom's explore. Tried to test with local grafana setup but it seems to have regressed so will follow-up on that.