[Backport 5.3.9104] scip-ctags: better error propagation #61847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects the error handling in scip-ctags, making it more consistent with universal-ctags. We now split errors into two classes: * Fatal: user command is invalid or incorrectly formatted, I/O errors. This indicates a big issue in how we're using ctags and we should fail hard. * Non-fatal: any file parsing issue (invalid UTF-8, unsupported language, or all symbols can't be parsed). Our go-ctags wrapper only reports fatal errors, and just logs non-fatal errors. We fail indexing for an entire Zoekt repo on go-ctags errors, which helps surface serious issues with ctags, while allowing parse failures for individual files. (cherry picked from commit 47ab5f5)
sourcegraph-release-bot
added
team/search-platform
jtibshirani
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects the error handling in scip-ctags, making it more
consistent with universal-ctags. We now split errors into two classes:
indicates a big issue in how we're using ctags and we should fail hard.
can't be parsed).
Our go-ctags wrapper only reports fatal errors, and just logs non-fatal errors.
We fail indexing for an entire Zoekt repo on go-ctags errors, which helps
surface serious issues with ctags, while allowing parse failures for individual files.
Fixes #61785
Fixes ENG-23595
Test plan
Added a new snapshot test for an error case, and made sure the output looked
good. Manual testing, including indexing the
github-linguist/linguistrepolocally and checking it now succeeds.
Backport 47ab5f5 from #61712