[Backport 5.3.9104] Context: fix bug with result limits #62054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While writing eval scripts for Cody context, I noticed that when searching multiple repos, we sometimes we return greater than the intended number of results. This PR makes a small fix so we always respect the result limits. (cherry picked from commit 6a4ac36)
sourcegraph-release-bot
added
team/search-platform
jtibshirani
approved these changes
Apr 19, 2024
jdpleiness
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing eval scripts for Cody context, I noticed that when searching
multiple repos, we sometimes we return greater than the intended number of
results. This PR makes a small fix so we always respect the result limits.
Test plan
This is hard to check through automated tests since it requires a certain set
of concurrent steps to occur. I tested manually before and after the change and
this fixed it.
Backport 6a4ac36 from #61806