Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitserver image to pull in libcurl fix #62079

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

willdollman
Copy link
Contributor

This PR updates the gitserver base image - it downgrades curl to 8.6.0 due to a regression in curl 8.7.0 that affects git fetch. As a side effect, a number of other packages are also upgraded but I don't foresee this being a problem assuming it passes all release tests.

Context from Slack

Image hash taken from https://buildkite.com/sourcegraph/sourcegraph/builds/270158. Updated image url from dockerhub to us.gcr.io as we no longer push to Dockerhub.

Running affected git fetch against broken sourcegraph/gitserver:5.3.9104 image:

Initialized empty Git repository in /data/repos/
error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400
fatal: unable to write request to remote: Broken pipe

Running against this base image:

Initialized empty Git repository in /data/repos/
remote: Enumerating objects: 2378395, done.
remote: Counting objects: 100% (8632/8632), done.
remote: Compressing objects: 100% (4701/4701), done.
Receiving objects:  25% (594599/2378395), 502.08 MiB | 31.11 MiB/s
[...]

Test plan

  • Tested image against problematic git command
  • CI

@willdollman willdollman self-assigned this Apr 22, 2024
@cla-bot cla-bot bot added the cla-signed label Apr 22, 2024
@willdollman willdollman requested a review from a team April 22, 2024 10:55
@willdollman willdollman added the release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases label Apr 22, 2024
@BolajiOlajide BolajiOlajide enabled auto-merge (squash) April 22, 2024 10:57
@BolajiOlajide BolajiOlajide merged commit 1b0e5c7 into 5.3.9104 Apr 22, 2024
9 checks passed
@BolajiOlajide BolajiOlajide deleted the will/update-gitserver-curlfix branch April 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants