Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 5.4.0] Batch changes: make window ranges exclusive to avoid infinite loop #62626

Merged
merged 1 commit into from
May 13, 2024
Merged

[Backport 5.4.0] Batch changes: make window ranges exclusive to avoid infinite loop #62626

merged 1 commit into from
May 13, 2024

Conversation

sourcegraph-release-bot
Copy link
Collaborator

This fixes an issue where we can potentially make no progress in the main loop of Estimate. Commentary inline.

Related Slack thread

Test plan

Added unit test for this case and fuzz test to search for other edge cases.


Backport 750012b from #62597

@camdencheek @github-actions
Batch changes: make window ranges exclusive to avoid infinite loop (#…
a1fab03 
…62597)

This fixes an issue where we can potentially make no progress in the main loop of Estimate

(cherry picked from commit 750012b)
@BolajiOlajide BolajiOlajide enabled auto-merge (squash) May 13, 2024 11:08
@BolajiOlajide BolajiOlajide merged commit c35e37a into 5.4.0 May 13, 2024
10 of 15 checks passed
@BolajiOlajide BolajiOlajide deleted the backport-62597-to-5.4.0 branch May 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BolajiOlajide BolajiOlajide BolajiOlajide approved these changes

@camdencheek camdencheek Awaiting requested review from camdencheek

Assignees
No one assigned
Labels
backported-to-5.4.0 backports cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sourcegraph-release-bot @BolajiOlajide @camdencheek