[Backport 5.4.0] gitserver(ListRefs): Fix type detection for lightweight tags #62674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In git, there exist two types of tags: Lightweight tags, those are boring old refs that live in refs/tags/ and point directly to a commit. And then there are annotated tags, those live in refs/tags/ too, but they don't point to a commit directly, instead they point to a tag object, which then points to a commit object. That is used to add a message to a tag. However, we didn't detect lightweight tags correctly, so they would be reported as Type: Branch (as they point to a commit). This PR fixes it. Test plan: Added tests and verified manually using gRPC UI. (cherry picked from commit 335133a)
sourcegraph-release-bot
added
cla-signed
backports
backport/bugfix
|
(Notifying @sourcegraph/source of a change that affects gitserver) |
graphite-app
bot
added
the
team/source
eseliger
approved these changes
May 14, 2024
Chickensoupwithrice
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In git, there exist two types of tags: Lightweight tags, those are boring old refs that live in refs/tags/ and point directly to a commit.
And then there are annotated tags, those live in refs/tags/ too, but they don't point to a commit directly, instead they point to a tag object, which then points to a commit object.
That is used to add a message to a tag.
However, we didn't detect lightweight tags correctly, so they would be reported as Type: Branch (as they point to a commit).
This PR fixes it.
Test plan:
Added tests and verified manually using gRPC UI.
Backport 335133a from #62671