Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooling): bump Go version to 1.22.4 #63124

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

Strum355
Copy link
Member

@Strum355 Strum355 commented Jun 6, 2024

Bump for @evict

Test plan

CI passes with no complaints

Changelog

  • Bumped version of Go used to build to 1.22.4

@Strum355 Strum355 requested review from evict and a team June 6, 2024 14:55
@Strum355 Strum355 self-assigned this Jun 6, 2024
@cla-bot cla-bot bot added the cla-signed label Jun 6, 2024
@evict
Copy link
Contributor

evict commented Jun 6, 2024

💨

@Strum355 Strum355 enabled auto-merge (squash) June 6, 2024 14:56
@Strum355 Strum355 merged commit bb178ba into main Jun 6, 2024
11 checks passed
@Strum355 Strum355 deleted the nsc/bump-go-version branch June 6, 2024 15:19
@keegancsmith
Copy link
Member

What is the benefit of specifying patch version in go.mod? From a development PoV it doesn't matter, and for our builds it we use the bazel version. I guess it kinda makes sense, and I just need to bite the NixOS not having 1.22.4 yet bullet.

@willdollman willdollman added the backport 5.4.5099 label used to backport PRs to the 5.4.5099 release branch label Jun 20, 2024
sourcegraph-release-bot pushed a commit that referenced this pull request Jun 20, 2024
Bump for @evict

## Test plan

CI passes with no complaints

## Changelog

- Bumped version of Go used to build to 1.22.4

(cherry picked from commit bb178ba)
willdollman pushed a commit that referenced this pull request Jun 20, 2024
Bump for @evict 

## Test plan

CI passes with no complaints

## Changelog

- Bumped version of Go used to build to 1.22.4
 <br> Backport bb178ba from #63124

Co-authored-by: Noah S-C <noah@sourcegraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 5.4.5099 label used to backport PRs to the 5.4.5099 release branch cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants