clearer access tokens allow check on dotcom #63368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+54
to
+60
| // 🚨 SECURITY: Creating access tokens for other users by site admins is not allowed on | ||
| // Sourcegraph.com. This check is mostly the defense for a misconfiguration of the site | ||
| // configuration. | ||
| if dotcom.SourcegraphDotComMode() { | ||
| if err := auth.CheckSameUser(ctx, userID); err != nil { | ||
| return nil, errors.New("access token creation for other users is disabled on Sourcegraph.com") | ||
| } | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.generic.comment-tagging-rule Note
Previously, the code would prevent us from using the AccessTokensAdmin config setting on dotcom entirely, instead of just restricting it when site admins create an access token for a different user, which was the intent.
sqs
force-pushed
the
sqs/clearer-dotcom-accesstok-check
branch
from
e8f5de3
to
1573522
Compare
keegancsmith
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code would prevent us from using the AccessTokensAdmin config setting on dotcom entirely, instead of just restricting it when site admins create an access token for a different user, which was the intent.
Test plan
CI