Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): build oci_push targets before invoking them #63381

Closed
wants to merge 1 commit into from

Conversation

Strum355
Copy link
Member

Today, we use gnu parallel to parallelize running bazel run on oci_push targets. Bazel cli holds an exclusive lock on the server while building, but releases the lock once it runs the excutable of a runnable target. By building the oci_push targets (and their closures) as part of bazel build, we can parallelize building instead of only one oci_push closure at a time, and then there should be minimal bazel server lock when we bazel run in parallel.

It's important we get the flags the same for bazel build and bazel run, hence stamp in both cases

Test plan

Awaiting a main dry-run

Changelog

@Strum355 Strum355 requested a review from a team June 20, 2024 10:05
@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
@Strum355 Strum355 closed this Jun 20, 2024
@Strum355 Strum355 deleted the nsc/pushall-prebuild branch June 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant