Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plg): require confirmation before removing user or revoking admin #63388

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

taras-yemets
Copy link
Contributor

@taras-yemets taras-yemets commented Jun 20, 2024

Closes #63240

Adds a confirmation modal before revoking admin or removing user.

Screenshot 2024-06-20 at 19 50 28 Screenshot 2024-06-20 at 19 50 36

Test plan

  • Run Sourcegraph instance in dotcom mode
    • Sign in as Cody Pro team site admin
    • Navigate to "/cody/team/manage" page
    • Click on remove button next to the team member
      • Ensure the confirmation modal is visible
      • Ensure clicking the cancel button closes the confirmation modal and user is not removed
      • Ensure clicking the confirm button removes the user and closes the confirmation modal
    • Click on the revoke admin button next to the team admin
      • Repeat steps for the user removal

Changelog

@taras-yemets
Copy link
Contributor Author

@rrhyne, I've just watched your Loom and now working on updating this PR accordingly (confirmation text messages, alert and button styles, etc.)

Copy link
Contributor

@vdavid vdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me, and if something is off, we can iterate from here.

client/web/src/cody/team/TeamMemberList.tsx Outdated Show resolved Hide resolved
@taras-yemets taras-yemets enabled auto-merge (squash) June 20, 2024 16:56
@taras-yemets taras-yemets merged commit 18f42a7 into main Jun 20, 2024
13 checks passed
@taras-yemets taras-yemets deleted the ty/plg-team-members-confirmation-modals branch June 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show confirmation dialog before removing a team member and revoking admin rights
2 participants