Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: self-managed comby dev dependency install #6902

Merged
merged 1 commit into from Nov 28, 2019

Conversation

rvantonder
Copy link
Contributor

@rvantonder rvantonder commented Nov 28, 2019

This updates documentation for installing comby as a dependency. There are constraints that make updating comby automatically in the dev scripts hard. These are, roughly:

  • binary distribution for different OSes
  • rapid iteration that require faster distribution than available through OS package managers, and
  • effort or extra time required when using toolchains and dependencies for building from source

If you are interested in more nitty gritty detail, see the slack thread.

Thus, for development, comby will now be a self-managed install, and treated as an external dependency. It is in fact optional unless you work with automation tooling at this point in time. Nothing changes for CI or deployments. There are many options for installing it so that:

  • Developers who aren't reliant on comby for development are unaffected (i.e., no broken dev builds, ever, and this is the priority behind this change.)
  • Developers who are reliant on comby but not the most recent versions can use, e.g., brew or grab the binaries from GH and put it on their PATH.
  • Developers who are reliant on recent versions with bug fixes or feature extensions can grab it directly from GH if it's not available on brew yet.

Test plan: N/A, that's part of the objective.

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #6902 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6902      +/-   ##
==========================================
+ Coverage   39.06%   39.13%   +0.07%     
==========================================
  Files        1231     1230       -1     
  Lines       63392    63271     -121     
  Branches     6064     6038      -26     
==========================================
- Hits        24765    24763       -2     
+ Misses      36362    36243     -119     
  Partials     2265     2265
Impacted Files Coverage Δ
cmd/frontend/graphqlbackend/repository.go 20.73% <0%> (-0.93%) ⬇️
web/src/regression/util/codenav.ts 0% <0%> (ø) ⬆️
...src/enterprise/site-admin/SiteAdminLsifJobPage.tsx 0% <0%> (ø) ⬆️
web/src/regression/util/codeintel.ts

@rvantonder rvantonder merged commit 026995f into master Nov 28, 2019
@rvantonder rvantonder deleted the rvt/comby-install-docs branch November 28, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants