use single root package.json, do not build intermediate shared code #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
ts-build
branch
2 times, most recently
from
653c31e
to
800dcbf
Compare
sqs
requested review from
dadlerj,
keegancsmith and
nicksnyder
as code owners
sqs
force-pushed
the
ts-build
branch
2 times, most recently
from
83d88d8
to
f4fc70a
Compare
sqs
changed the title
|
@ijsnow the browser extension has been moved to @felixfbecker the web app has been moved to @chrismwendt extensions-client-common and all impl code for Sourcegraph extensions has been moved to |
| # Sourcegraph browser extensions | ||
|
|
||
| [](https://travis-ci.org/sourcegraph/browser-extensions) | ||
| [](https://david-dm.org/sourcegraph/browser-extensions) |
There was a problem hiding this comment.
This badge doesn't work anymore because it references the old repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch uses a single root package.json. See https://sourcegraph.com/github.com/sourcegraph/sourcegraph@master/-/blob/doc/dev/typescript/build.md and https://sourcegraph.slack.com/archives/C07KZF47K/p1541878567271600 for context.
I am going to merge it now because (1) the plan has been reviewed/discussed already and the PR is not going to be very useful to review since it's so large/mechanical, and (2) it would otherwise start generating a lot of merge conflicts.