New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite precise-code-intel-bundle-manager in Go #9586
Conversation
afb4900
to
864bd1e
Compare
bc21841
to
a8dc7e3
Compare
f36f7bf
to
d2e9585
Compare
Codecov Report
@@ Coverage Diff @@
## master #9586 +/- ##
==========================================
+ Coverage 42.74% 42.95% +0.20%
==========================================
Files 1348 1354 +6
Lines 74083 74693 +610
Branches 6651 6651
==========================================
+ Hits 31668 32081 +413
- Misses 39562 39692 +130
- Partials 2853 2920 +67
|
ea26ee1
to
98b4a41
Compare
I haven't done reviewing the PRs, just some notes (for discussions) on skimming the files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting my partial reviews so number of comments aren't overwhelming. Very enjoyable piece of code though!
cmd/precise-code-intel-bundle-manager/internal/database/cache_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/cache_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/cache_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/cache.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Approve to unblock.
cmd/precise-code-intel-bundle-manager/internal/database/database_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/database_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/database/ranges_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/janitor/janitor_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/janitor/janitor_test.go
Outdated
Show resolved
Hide resolved
cmd/precise-code-intel-bundle-manager/internal/types/unmarshal_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn't deeply review due to size. Rather just took a high level view over it to see anything that stood out. So sorry for only finding nits :) Nice work!
This is a rewrite of the precise-code-intel-bundle-manager in Go. This does not change the current entrypoints as we're not ready to switch to the new code yet. I am planning on manually testing requests against the old and new servers to ensure the behavior is the same during usage. A follow-up PR(s) will remove the old code and switch to the new code in build and deployment environments.
This new code is fairly well tested (database: 79.2% coverage, janitor: 62.4% coverage, and types: 79.0%). The server code will be more fully tested before it replaces the existing TypeScript code.
This new code needs to emit metric, add tracing to requests, and wrap errors properly before being considered ready for production.
Opening PR now for discussion as it's a large chunk of code. This effort is tracked in #9964.