Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar to lsif upload command #243

Merged
merged 3 commits into from Jul 8, 2020
Merged

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Jul 5, 2020

This update enables retries on each upload part (10 retries per part with a 1/4 second interval between attempts), and also draws an upload progress bar if the -json flag is not supplied.

This covers the retries task in sourcegraph/sourcegraph#11876.

@efritz efritz requested a review from shrouxm July 5, 2020 22:19
Copy link
Contributor

@shrouxm shrouxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efritz efritz merged commit d205151 into master Jul 8, 2020
@efritz efritz deleted the lsif-upload-progress branch July 8, 2020 00:14
scjohns pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants