-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old feature gates from pre-4.0 #822
Conversation
685b513
to
fc3fa34
Compare
d1039a3
to
efd1d7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm mentally preparing myself for the merge conflict I'm going to have to go thru.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -604,3 +583,14 @@ func getBatchParallelism(ctx context.Context, flag int) (int, error) { | |||
|
|||
return docker.NCPU(ctx) | |||
} | |||
|
|||
func validateSourcegraphVersionConstraint(ctx context.Context, svc *service.Service) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry a little that this may be too simplistic as we start adding things in 4.x again, but let's cross that bridge when we get to it.
Co-authored-by: Adam Harvey <adam@adamharvey.name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DELETE 👏 IT 👏 ALL 👏
Requires a newer Sourcegraph version from sourcegraph/sourcegraph#40446.
This also adds a feature gate for sourcegraph 4.0 to src-cli to warn users when they use a too recent version of src-cli.
Closes sourcegraph/sourcegraph#38969
Closes sourcegraph/sourcegraph#38967
Test plan
Test suite and verified manually the 4.0 banner and previous functionality work.