Feature/mac os saves directory correct fix #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tform dependent code to get 'Documents' directory, unfortunately there is no generic way to do that). Remove unnecessary scripts. Update README.md.
skrax
reviewed
Feb 8, 2021
CMakeLists.txt
Outdated
| @@ -69,6 +73,10 @@ else() | |||
| add_definitions(-Wno-reorder -pedantic-errors -Ofast -fno-fast-math) | |||
| endif() | |||
|
|
|||
| if(MAC_OS) | |||
There was a problem hiding this comment.
For now this is okay, but in the future we want to move away from piling onto a sourcelist.
Perhaps you could add a CMake target instead?
There was a problem hiding this comment.
I am not familiar with CMake. Will investigate how to do that.
There was a problem hiding this comment.
By the way, can you recommend some CMake tutorial?
There was a problem hiding this comment.
Checkout CppCon talks on CMake.
I can also recommend this: https://cliutils.gitlab.io/modern-cmake/
…on Mac OS using cmake (properly handle frameworks).
|
Fixed conflicts and build on Mac OS. Please, take a look. |
atmaxinger
reviewed
Feb 9, 2021
CMakeLists.txt
Outdated
|
|
||
| # MacOSUtils | ||
| if(MAC_OS) | ||
| add_library(MacOSUtils macOS/src/PathUtils.m) |
There was a problem hiding this comment.
The directory is called macos in lowercase, so this line breaks the build on Linux
…E_SYSTEM_NAME is not set in all cases.
|
Now it works as intended. Sorry for the mess with commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add correct fix for 'missed saves directory' error (I have to add platform dependent code to get 'Documents' directory, unfortunately there is no generic way to do that). Remove unnecessary scripts. Update README.md.