Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deps is broken as a golangci-lint dep needs golangv1.19 #1076

Closed
shahzadlone opened this issue Feb 7, 2023 · 1 comment
Closed

make deps is broken as a golangci-lint dep needs golangv1.19 #1076

shahzadlone opened this issue Feb 7, 2023 · 1 comment
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies
Milestone
DefraDB v0.5

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Feb 7, 2023 •
edited

Since yesterday (or 4 days ago).

GoLang-Ci Lint updated tov1.51.0 and v1.51.1.

A dependency of it was updated to require golang 1.19, which breaks the make deps rule:

go install golang.org/x/perf/cmd/benchstat@latest
go install github.com/git-chglog/git-chglog/cmd/git-chglog@latest
go install github.com/ory/go-acc@latest
go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
go: downloading github.com/golangci/golangci-lint v1.51.1
go: downloading github.com/gordonklaus/ineffassign v0.0.0-20230107090616-13ace0543b28
go: downloading github.com/junk1tm/musttag v0.4.4
go: downloading github.com/nunnatsa/ginkgolinter v0.8.1
go: downloading github.com/ryanrolds/sqlclosecheck v0.4.0
go: downloading github.com/sanposhiho/wastedassign/v2 v2.0.7
go: downloading github.com/sourcegraph/go-diff v0.7.0
go: downloading github.com/tomarrell/wrapcheck/v2 v2.8.0
go: downloading honnef.co/go/tools v0.4.0
go: downloading github.com/go-toolsmith/astcopy v1.0.3
# honnef.co/go/tools/unused
../../../go/pkg/mod/honnef.co/go/tools@v0.4.0/unused/unused.go:419:14: obj.Origin undefined (type *types.Var has no field or method Origin)
../../../go/pkg/mod/honnef.co/go/tools@v0.4.0/unused/unused.go:421:14: obj.Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
# honnef.co/go/tools/staticcheck
../../../go/pkg/mod/honnef.co/go/tools@v0.4.0/staticcheck/lint.go:4032:29: righti.Method(i).Origin undefined (type *types.Func has no field or method Origin)
../../../go/pkg/mod/honnef.co/go/tools@v0.4.0/staticcheck/lint.go:4037:36: sel.Obj().(*types.Func).Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
make[1]: *** [Makefile:68: deps:lint] Error 2
make: *** [Makefile:92: deps] Error 2

building defradb dependencies failed.

This will also break any scripts that depend on make deps to for example build defradb deps and install defradb (use make deps:modules instead).

  1. We should hard code golangci-lint version in the deps (and the lint action for example in this PR chore: Bump to GoLang v1.19 #818 .
@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies labels Feb 7, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Feb 7, 2023
@shahzadlone shahzadlone self-assigned this Feb 7, 2023
@shahzadlone shahzadlone mentioned this issue Feb 7, 2023
Merged
4 tasks
shahzadlone added a commit that referenced this issue Feb 7, 2023
@shahzadlone
ci: Add workflow to ensure deps build properly (#1078)
5591416 
- Resolves #1077
- Resolves #1075
- Resolves-Partially #1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
@shahzadlone
Copy link
Member Author

was fixed: #818

@jsimnz jsimnz closed this as completed Mar 23, 2023
shahzadlone added a commit that referenced this issue Apr 13, 2023
@shahzadlone
ci: Add workflow to ensure deps build properly (#1078)
deb65e7 
- Resolves #1077
- Resolves #1075
- Resolves-Partially #1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
ci: Add workflow to ensure deps build properly (sourcenetwork#1078)
24ba329 
- Resolves sourcenetwork#1077
- Resolves sourcenetwork#1075
- Resolves-Partially sourcenetwork#1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality dependencies Related to dependencies
Projects
None yet
Milestone
DefraDB v0.5
Development

No branches or pull requests
2 participants
@jsimnz @shahzadlone