Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add workflow to ensure deps build properly #1078

Merged
merged 6 commits into from
Feb 7, 2023
Merged

ci: Add workflow to ensure deps build properly #1078

merged 6 commits into from
Feb 7, 2023

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Feb 7, 2023 •
edited
Loading

Relevant issue(s)

Resolves #1077
Resolves #1075
Resolves-Partially #1076

Description

  • Updated to new PATv2 (in the secrets) and updated with the new PAT name ONLY_DEFRADB_REPO_CI_PAT.
  • Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
  • Add the deploy script that was written for cloning defradb on the cloud infra.
  • Added missing headers in workflow files.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI & Locally

Specify the platform(s) on which this was tested:

  • WSL2 Ubuntu & Manjaro

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels Feb 7, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Feb 7, 2023
@shahzadlone shahzadlone self-assigned this Feb 7, 2023
@shahzadlone shahzadlone force-pushed the lone/ci/add-ci-to-ensure-deps-are-valid branch from 409a6ea to 0fa0465 Compare February 7, 2023 06:14
@source-devs

This comment was marked as off-topic.

Sign in to view
@source-devs source-devs requested a review from a team February 7, 2023 06:29
@source-devs source-devs marked this pull request as ready for review February 7, 2023 06:30
@source-devs

This comment was marked as off-topic.

Sign in to view
@source-devs source-devs added the action/no-benchmark Skips the action that runs the benchmark. label Feb 7, 2023
@shahzadlone shahzadlone force-pushed the lone/ci/add-ci-to-ensure-deps-are-valid branch from 26b8095 to ca6c979 Compare February 7, 2023 06:41
@sourcenetwork sourcenetwork deleted a comment from source-devs Feb 7, 2023
@shahzadlone shahzadlone force-pushed the lone/ci/add-ci-to-ensure-deps-are-valid branch from ca6c979 to fcabb10 Compare February 7, 2023 06:50
orpheuslummis
orpheuslummis approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM conditional on the suggestion being addressed

.github/workflows/lint-then-benchmark.yml Show resolved Hide resolved
tools/scripts/deploy_defradb.sh Show resolved Hide resolved
fredcarle
fredcarle approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone merged commit 5591416 into develop Feb 7, 2023
@shahzadlone shahzadlone deleted the lone/ci/add-ci-to-ensure-deps-are-valid branch February 7, 2023 15:44
shahzadlone added a commit that referenced this pull request Apr 13, 2023
@shahzadlone
ci: Add workflow to ensure deps build properly (#1078)
deb65e7 
- Resolves #1077
- Resolves #1075
- Resolves-Partially #1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Add workflow to ensure deps build properly (sourcenetwork#1078)
24ba329 
- Resolves sourcenetwork#1077
- Resolves sourcenetwork#1075
- Resolves-Partially sourcenetwork#1076 
- Updated to new PATv2 (in the secrets) and updated with the new PAT name `ONLY_DEFRADB_REPO_CI_PAT`.
- Add a new CI workflow to test our dependency-building steps are not broken (not required for PR to merge).
- Add the deploy script that was written for cloning defradb on the cloud infra.
- Added missing headers in workflow files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.5
4 participants
@shahzadlone @source-devs @orpheuslummis @fredcarle