use ExtractorBase for Swift #346
Conversation
| } | ||
| object SwiftExtractor : ExtractorBase( | ||
| language = Lang.SWIFT, | ||
| importRegex = Regex("""^(.*import)\s[^\n]*"""), |
There was a problem hiding this comment.
extractImportRegex used for actually extracting of imports for choosing right classifiers
importRegex used to filter tokens from imports and as @yaronskaya works slightly faster
Here importRegex (less accurate version) used for both extracting and filter tokens. @yaronskaya review this change.
There was a problem hiding this comment.
@anatolystansler Curious, whether it is noticeable at all. Having two nearly identical regexps affects on code readability and its maintenance. So if it's not a perf problem, then I would choose simplicity over optimization.
There was a problem hiding this comment.
@asurkov this regex doesn't extract imports. Please, use 'extractImportRegex' from previous version of SwiftExtractor. I wonder if it passes tests:)
| } | ||
| object SwiftExtractor : ExtractorBase( | ||
| language = Lang.SWIFT, | ||
| importRegex = Regex("""^(.*import)\s[^\n]*"""), |
There was a problem hiding this comment.
@asurkov this regex doesn't extract imports. Please, use 'extractImportRegex' from previous version of SwiftExtractor. I wonder if it passes tests:)
|
@yaronskaya now I see what you say. The tests indeed pass, which means it has to be a problem with the tests. For example, there's one |
|
@asurkov it turned out that we don't have tests of imports for Swift, there are only tests for libraries extraction. Could you please add them? |
| "import UIKit" | ||
| ) | ||
| var actualLineImports = SwiftExtractor.extractImports(lines) | ||
| assertEquals(actualLineImports, listOf("UIKit")) |
There was a problem hiding this comment.
Use assertExtractsImport
No description provided.