Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 455 install.sh fix for CentOS 6 #456

Merged
merged 3 commits into from
Oct 10, 2017
Merged

Conversation

zbeekman
Copy link
Collaborator

@zbeekman zbeekman commented Oct 10, 2017

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

Fixed typo triggered when MPI missing in CMakeLists.txt, fixed stack.sh functionality on bash 4.1, and partially fixed installing GCC prereqs on CentOS 6.

Rationale for changes

stack.sh failing with bash 4.1, typo in CMakeListsts.txt, some utils (yacc) don't accept --version

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I reviewed and followed the contributing guidelines, including
    - Increasing test coverage for all feature-addition PRs
    - Increasing test coverage for all bug-fix PRs for which there
    does not already exist a related test that failed before the PR
    - At least maintaining test coverage for all other PRs
    - Ensuring that all tests pass when run locally
    - Naming PR to indicate work in progress (WIP) and to attach the PR
    to the appropriate bug report or feature request issue
    - White space (no trailing white space or white space errors may
    be introduced)
    - Commenting code where it is non-obvious and non-trivial
    - Logically atomic, self consistent and coherent commits
    - Commit message content
    - Waiting 24 hours before self-approving the PR to give another
    OpenCoarrays developer a chance to review my proposed code

 - Script assumed all executables take --version argument,
   older yaccs only have -V, not uncommon among unix tools
@codecov
Copy link

codecov bot commented Oct 10, 2017

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files           3        3           
  Lines        2105     2105           
  Branches      350      350           
=======================================
  Hits          743      743           
  Misses       1154     1154           
  Partials      208      208

@zbeekman
Copy link
Collaborator Author

Need to fix bad curl url on CentOS 6... curl doesn't like ftp://my.server.org:/path/to/file and I don't think it will resolve the host. Decent chance removing the second colon fixes the problem, may need to remove the ftp:// too.

@rouson do you know which systems need the ftp capability? If we changed the URL to be a sane one, then curl and wget would have a better shot at actually fetching gcc and prereqs.

@zbeekman
Copy link
Collaborator Author

zbeekman commented Oct 10, 2017

LGTM

outstanding issues (ftp url with curl on CentOS6) remain, but this is a step in the right direction

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant