Use PIC for (default) static lib #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`caf` wrapper script defaults to static linkage against libcaf_mpi.a but if you're building a shared lib with the `caf` script this fails because objects in `libcaf_mpi.a` are not compiled with `-fPIC`. So creating shared libs fails. The wrapper script should probably default to building and linking against the shared lib
ghost
assigned 
|
Fixes #635 |
The LD_LIB_P_VAR *should* be *once* de-referenced in the echo statements within `prerequisits/install-functions/report_results.sh` so that it takes the value of `LD_LIBRARY_PATH` or `DYLD_LIBRARY_PATH` in the setup script, which then checks if the user has anything set here and decides whether to add additional search paths (if they have it set) or set it directly if it is empty.
|
LGTM pending CI tests passing. |
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 55.73% 55.73%
=======================================
Files 4 4
Lines 3158 3158
=======================================
Hits 1760 1760
Misses 1398 1398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cafwrapper script defaults to static linkage against libcaf_mpi.a but if you'rebuilding a shared lib with the
cafscript this fails because objects inlibcaf_mpi.aare not compiled with
-fPIC. So creating shared libs fails.The wrapper script should probably default to building and linking against the shared lib
Summary of changes
Always compile position independent code so that the caf wrapper script can build shared libs. Probably, the better solution is to link against the shared lib by default.
Rationale for changes
Allow
cafto compile JSON-FortranAdditional info and certifications
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code