Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PIC for (default) static lib #639

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Use PIC for (default) static lib #639

merged 2 commits into from
Mar 18, 2019

Commits on Mar 18, 2019

  1. Use PIC for (default) static lib 

     `caf` wrapper script defaults to static linkage against libcaf_mpi.a but if you're
 building a shared lib with the `caf` script this fails because objects in `libcaf_mpi.a`
 are not compiled with `-fPIC`. So creating shared libs fails.

 The wrapper script should probably default to building and linking against the shared lib
    @zbeekman
    zbeekman committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    1f0770b View commit details
    Browse the repository at this point in the history

  2. Fix #629 

     The LD_LIB_P_VAR *should* be *once* de-referenced in the echo statements within
 `prerequisits/install-functions/report_results.sh` so that it takes the value of
 `LD_LIBRARY_PATH` or `DYLD_LIBRARY_PATH` in the setup script, which then checks
 if the user has anything set here and decides whether to add additional search
 paths (if they have it set) or set it directly if it is empty.
    @zbeekman
    zbeekman committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    e7a9bdf View commit details
    Browse the repository at this point in the history