Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 727 co broadcast on mixed derived type #751

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Feb 14, 2022

coverage on master
Codecov branch

Summary of changes

Add unit tests and debugging that issue #727 is fixed.

Rationale for changes

Prove that #727 is fixed in the compiler (gcc > 12.0.0 or gcc > 11.2.1 (or current release/gcc-11 branch).

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe: Check fix in compiler

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

@vehre
Copy link
Collaborator Author

vehre commented Feb 14, 2022

Note this MR is against #745.

Base automatically changed from issue-745-rename-co_reduce-operator-for-F2018 to main February 14, 2022 20:04
Copy link
Member

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit 31f7f18 into main Feb 14, 2022
@rouson rouson deleted the issue-727-co-broadcast-on-mixed-derived-type branch February 14, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants