Support to enable or disable the 'Open repo in Remix' link

[acuarica]

Related to ethereum/sourcify#1385, this PR adds support to enable (default) or disable the 'Open repo in Remix' link.

It does so by setting the Docker build argument HIDE_OPEN_IN_REMIX. When set to 1 it will hide the link. Otherwise it leaves it unchanged (default).

When HIDE_OPEN_IN_REMIX is set to 1, a patch to remove the link is applied. The patch was originally created here hashgraph/hedera-sourcify#69.

[marcocastignoli]

Hey @acuarica, this works. But I think that injecting an object in the javascript is better. So instead of using a git patch we can:
1.

ARG HIDE_OPEN_IN_REMIX
COPY hide-open-in-remix.patch /hide-open-in-remix.patch 
RUN if [ "$HIDE_OPEN_IN_REMIX" = "1" ]; then 
   cd h5ai;
   # Push to a new new custom.js `{ hideOpenInRemix: true }`;
fi

3. Inside a/src/_h5ai/public/js/lib/view/view.js b/src/_h5ai/public/js/lib/view/view.js import that config file and manage the case with a js condition

What do you think?

[acuarica]

Hi @marcocastignoli, thanks for taking the time to take a look at this.

The main issue I see is that view.js comes from yet another repo. I chose to modify it with a patch to avoid modifying yet another level repo.

Having a js condition means to evaluate this at runtime. Given this is a build time flag, patching at build time doesn't sound too bad and it looks clearer what is the intent.

[marcocastignoli]

Ok then 👍