Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to enable or disable the "Open repo in Remix" link in repository #1385

Closed
acuarica opened this issue May 7, 2024 · 5 comments
Closed

Comments

@acuarica
Copy link
Contributor

acuarica commented May 7, 2024

Even if this issue might belong to the submodule https://github.com/sourcifyeth/h5ai-nginx, I opened the issue here for triaging.

The repository service provides a link to open each verified contract in Remix.

However, for public self-hosted Sourcify instances (like in the case of Hedera) the Open repo in Remix link does not work, given the Remix plugin only fetches contracts from https://repo.sourcify.dev.

  1. Is it worth to add support to enable/disable this link?
  2. Is it worth to customize the Remix plugin to support public self-hosted Sourcify instances?
@kuzdogan
Copy link
Member

kuzdogan commented May 7, 2024

Hello :)

  1. Yes we can add support to enable/disable this link (on the build step). Maybe even better we can add a custom link for that, if it does not take too much effort
  2. The Remix plugin wouldn't be worth as we're working on a new unified verification plugin [Milestone] Remix "Verifier" Plugin #1331. The new plugin will have custom Sourcify URLs. I'd estimate it to take 2-3 months. Does this timeline work for you?

@acuarica
Copy link
Contributor Author

Hi @kuzdogan,

  1. Sounds good. We currently disable this link by patching the contract view. We could apply this strategy conditionally at build time. What do you think? I can send a PR in the subrepo to showcase this.
  2. Totally, this works for us.

Thanks!

@kuzdogan
Copy link
Member

Great feel free to submit a PR :)

@acuarica
Copy link
Contributor Author

Sent the PR here sourcifyeth/h5ai-nginx#5. Let me know if this is a fair solution. I know that patching may be odd, but that's the solution we had to modify the repo cloned inside the container.

@acuarica
Copy link
Contributor Author

PR sourcifyeth/h5ai-nginx#5 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants