remove error for short sequences

sourmash-bio · Jun 6, 2016 · 494cc9d · 494cc9d
1 parent 5f899db
commit 494cc9d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/sourmash_lib/kmer_min_hash.hh b/sourmash_lib/kmer_min_hash.hh
@@ -57,7 +57,7 @@ public:
     }
     void add_sequence(const char * sequence, bool force=false) {
         if (strlen(sequence) < ksize) {
-            throw minhash_exception("sequence is shorter than ksize");
+            return;
         }
         const std::string seq = _checkdna(sequence, force);
         if (!is_protein) {

diff --git a/sourmash_lib/test__minhash.py b/sourmash_lib/test__minhash.py
@@ -376,11 +376,9 @@ def test_mh_concat_diff_ksize():
 
 def test_short_sequence():
     a = MinHash(20, 5)
-    try:
-        a.add_sequence('GGGG')
-        assert 0, "adding too short a sequence should trigger ValueError"
-    except ValueError:
-        pass
+    a.add_sequence('GGGG')
+    # adding a short sequence should fail silently
+    assert len(a.get_mins()) == 0
 
 
 def test_murmur():