Skip to content

Commit

Permalink
[MRG] change cargo update to do a dry-run only (#2388)
Browse files Browse the repository at this point in the history
This PR continues the cibuildwheel exploration that started with a fix
for building the wheels
(#2384 and #2385).

The saga continues like so:

When building the release candidates, we don't get "clean" rcN wheels. I
think this is because when I run `cargo update` in the cibuildwheel
action it's actually updating the Rust packages and we're getting a
version bump from that. Yay? (See screenshot of releases page with 'dev'
yada in wheel names.)

<img width="1025" alt="Screen Shot 2022-12-02 at 7 15 52 AM"
src="https://user-images.githubusercontent.com/51016/205325234-9ec0c6c2-7cbc-42c7-9727-fd700ef59320.png">

This PR changes `cargo update` to `cargo update --dry-run` which should
update the crates.io index without actually changing `Cargo.lock` and
pushing a version bump.

We Shall See!
  • Loading branch information
ctb committed Dec 2, 2022
1 parent 281ad98 commit fe7e417
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .ci/install_cargo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ export PATH="$HOME/.cargo/bin:$PATH"
rustc -V
rustup target add aarch64-apple-darwin

# update crates.io index without updating Cargo.lock
export CARGO_NET_GIT_FETCH_WITH_CLI=true
cargo update
cargo update --dry-run
2 changes: 1 addition & 1 deletion .github/workflows/build_wheel_all_archs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: cibuildwheel_ubuntu

on:
#pull_request: # use for testing modifications to this action
pull_request: # use for testing modifications to this action
push:
branches: [latest]
tags: v*
Expand Down

0 comments on commit fe7e417

Please sign in to comment.