Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add / resolve issues with release process documentation #1109

Closed
ctb opened this issue Jul 18, 2020 · 2 comments · Fixed by #1125
Closed

add / resolve issues with release process documentation #1109

ctb opened this issue Jul 18, 2020 · 2 comments · Fixed by #1125

Comments

@ctb
Copy link
Contributor

ctb commented Jul 18, 2020

(this extracts still-relevant issues from the meandering discussion in #955)

the sourmash releases page has weird releases show up, e.g. https://github.com/dib-lab/sourmash/releases/tag/r0.9.0. I think they're from the release candidates? Or maybe the rust builds? What should we do about them, if anything?

I note on https://pypi.org/project/sourmash/3.2.3/ that the first line of the README shows up, <meta charset="utf-8"/>. Should we fix/remove?

@ctb ctb changed the title add / resolve issues with release notes add / resolve issues with release process documentation Jul 18, 2020
@luizirber
Copy link
Member

the sourmash releases page has weird releases show up, e.g. https://github.com/dib-lab/sourmash/releases/tag/r0.9.0. I think they're from the release candidates? Or maybe the rust builds? What should we do about them, if anything?

They are the core rust versions, which are versioned differently than sourmash. These tags are the versions published in https://crates.io/crates/sourmash.

I'll try to find if there is a way to hide them in releases...

I note on https://pypi.org/project/sourmash/3.2.3/ that the first line of the README shows up, <meta charset="utf-8"/>. Should we fix/remove?

Yes, remove. This is something for crates.io display, but now the README for it comes from src/core/README.md, so no good reason to mess the PyPI display.

@ctb
Copy link
Contributor Author

ctb commented Jul 25, 2020

between them, #1124 and #1125 will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants