Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve sourmash deprecation warnings for 4.0 release #1296

Closed
ctb opened this issue Feb 1, 2021 · 4 comments · Fixed by #1301
Closed

resolve sourmash deprecation warnings for 4.0 release #1296

ctb opened this issue Feb 1, 2021 · 4 comments · Fixed by #1301
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Feb 1, 2021

the tests currently spit out a LOT of warnings. fixme.
@ctb ctb mentioned this issue Feb 4, 2021
Merged
5 tasks
@ctb ctb added the 4.0 issues to address for a 4.0 release label Feb 4, 2021
@ctb ctb closed this as completed in #1301 Feb 5, 2021
@luizirber
Copy link
Member

Turns out new ones appeared, related to load_signatures/load_file_as_signatures. Reopening.

@luizirber luizirber reopened this Feb 5, 2021
@ctb
Copy link
Contributor Author

ctb commented Feb 5, 2021

I found running py.test -Werror to be useful in cleaning up the new ones. Do you think we should enable that by default in the testing?

@ctb ctb mentioned this issue Feb 5, 2021
Merged
5 tasks
@luizirber
Copy link
Member

I found running py.test -Werror to be useful in cleaning up the new ones. Do you think we should enable that by default in the testing?

Yup! It might be a bit scary for new people, tho. One solution would be enabling only in CI (like we do with PYTHONDEVMODE), but that might be even more confusing ("why does it pass locally, but fail in the PR checks?")

@ctb
Copy link
Contributor Author

ctb commented Feb 6, 2021

agreed. for now, I'll just keep an eye on it for future PRs.

@ctb ctb closed this as completed Feb 6, 2021
@luizirber luizirber mentioned this issue Feb 8, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Fix max hash deprecation warnings sourmash-bio/sourmash
2 participants
@luizirber @ctb