Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider renaming Rust merge function #1305

Open
ctb opened this issue Feb 5, 2021 · 0 comments
Open

consider renaming Rust merge function #1305

ctb opened this issue Feb 5, 2021 · 0 comments
Labels
rust

Comments

@ctb
Copy link
Contributor

ctb commented Feb 5, 2021

#1282 adjusts the Python API's meaning of merge to be in-place, and separates merge from __iadd__/+=. Does the Rust API need to be adjusted? Right now it's just using merge.

This is an honest question, I think it might be ok to leave it as is; but we should be sure to make it rust-y.
@ctb ctb added the rust label Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb