-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Refactor/expand MinHash add, iadd, and merge functionality. #1282
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1282 +/- ##
==========================================
+ Coverage 88.70% 93.96% +5.26%
==========================================
Files 125 98 -27
Lines 18296 14758 -3538
Branches 1437 1438 +1
==========================================
- Hits 16229 13868 -2361
+ Misses 1822 643 -1179
- Partials 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review @luizirber |
This PR does a few things -
MinHash.merge
to be only in-place, with no return value__add__
method.Fixes #1211
TODO:
merge
functionChecklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?