Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request that Index provide a location? #1377

Closed
ctb opened this issue Mar 8, 2021 · 1 comment · Fixed by #1392
Closed

Request that Index provide a location? #1377

ctb opened this issue Mar 8, 2021 · 1 comment · Fixed by #1392

Comments

@ctb
Copy link
Contributor

ctb commented Mar 8, 2021

In #1373, I added a location attribute to SBTs. We have something similar in LinearIndex and LCA_Database already (filename), and could add it to MultiIndex in #1374 as well.

The idea would be to provide a programmatic identifier for the location from which a database was loaded. In an ideal world, this would be something that the .load(...) function for that Index class could understand, although I don't want to require that just yet as it seems restrictive for in-memory Index classes.

In the case where a location was not available or did not make sense, it would be left as None.

See this comment on ZipFile for some thoughts on URL schemes to maybe use for this.

@ctb ctb changed the title Require that Index provide a location? Request that Index provide a location? Mar 8, 2021
@ctb
Copy link
Contributor Author

ctb commented Mar 8, 2021

note that filename in the header for CSV output for search and gather should be changed to location for 5.0, if we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant