-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notes on versioning and PRs #655
Comments
The Julia release process |
Pandas deprecation policy: https://dev.pandas.io/docs/whatsnew/v1.0.0.html#new-deprecation-policy |
https://twitter.com/adrinjalali/status/1442048926274801669
I'm not 100% sure I understand this fully, but the magic seems to be here -
which checks the scikit-learn version explicitly, and does different things depending on version. |
Goal:
master
branch is always releasedBuild system changes
Part of the problem of doing new releases is that we need to tag and test
the tag manually. Automate it!
I think the auto bump bot in bioconda can pick up our new versions without we needing to open a new PR thereYup! Already works.Checklist changes
I don't think we need to enforce it, but it would help whoever is merging to
have the PR submitter suggest what changes are being proposed. We can define
some broad categories based on conventional commits:
https://www.conventionalcommits.org/en/v1.0.0-beta.2/
Suggestion:
patch: bugfixes, no new features or breaking changes in APIs. Version bump
from
x.x.1
tox.x.2
.feature: minor version bump (x.0.0 to x.1.0).
chore: updates to build system, no version change.
doc: updates to documentation.
BREAKING CHANGE: this is a major version bump (2.x.x to 3.0.0), and we would
like to avoid this as much as possible (but we shouldn't be afraid of doing
them!). Whenever we remove an API, or change how we call functions.
for
doc
andchore
no version change is required, but may be good todo a patch bump (x.x.1 to x.x.2) to keep with the goal of always have
master
tagged and released.
Use more github templates
See https://github.com/datrs/hypercore/tree/master/.github for inspiration (I didn't even know it was possible to have multiple issue templates!)
Other changes
Benchmarks! Extend benchmarks #128
Since we have the WIP bot we don't need the [WIP] and [MRG] tags in the titleGitHub released 'draft PR', so I don't even think we need theanymore (we can put it in the PR description). This also avoids we merging
things with [MRG] commit messages into master =P
[WIP]
and[MRG]
tags anymoreThe text was updated successfully, but these errors were encountered: