Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating developer information with docs building instructions #1582

Open
wants to merge 12 commits into
base: latest
Choose a base branch
from
Open

Conversation

mr-eyes
Copy link
Member

@mr-eyes mr-eyes commented Jun 11, 2021

This PR to update the developer information page with:
- How to build Python and Rust docs?
- How to install Sourmash in editable mode?

In order to use Sourmash in the command line interface or the API while developing, you will need to install it in your enviornment in editable mode by running

```
pip install -e .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install -e .
pip install -e ".[test]"

ref #1482

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I'm not certain if you can do this with just this command, or if you need both...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luizirber can you please post your recommended set of commands using tox?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use tox -e docs for building the Python docs, and I don't use editable mode. If needed, then I use
tox -e dev
and follow the instructions for activating the new environment (usually
source .tox/dev/bin/activate
but can be
conda activate .tox/dev
for people using tox-conda)

doc/developer.md Outdated Show resolved Hide resolved
doc/developer.md Outdated Show resolved Hide resolved
doc/developer.md Outdated Show resolved Hide resolved
doc/developer.md Outdated Show resolved Hide resolved
doc/developer.md Outdated Show resolved Hide resolved
doc/developer.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1582 (9972b36) into latest (6b5806c) will increase coverage by 8.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1582      +/-   ##
==========================================
+ Coverage   81.10%   89.28%   +8.18%     
==========================================
  Files         102       75      -27     
  Lines       10334     6626    -3708     
  Branches     1171     1171              
==========================================
- Hits         8381     5916    -2465     
+ Misses       1748      505    -1243     
  Partials      205      205              
Flag Coverage Δ
python 89.28% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/encodings.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/from.rs
src/core/src/index/search.rs
src/core/src/lib.rs
src/core/src/index/linear.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/sketch/minhash.rs
src/core/tests/test.rs
src/core/tests/minhash.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5806c...9972b36. Read the comment docs.

mr-eyes and others added 7 commits June 11, 2021 23:52
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #1582 (e4cdd85) into latest (b787b75) will increase coverage by 22.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           latest    #1582       +/-   ##
===========================================
+ Coverage   66.47%   89.34%   +22.86%     
===========================================
  Files          27       76       +49     
  Lines        3708     6717     +3009     
  Branches        0     1198     +1198     
===========================================
+ Hits         2465     6001     +3536     
+ Misses       1243      507      -736     
- Partials        0      209      +209     
Flag Coverage Δ
python 89.34% <ø> (?)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/ffi/utils.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/lib.rs
src/core/src/from.rs
src/core/src/wasm.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/minhash.rs
src/core/src/index/mod.rs
src/core/src/ffi/signature.rs
src/core/src/encodings.rs
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b787b75...e4cdd85. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants