Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] remove unnecessary downsampling warnings #1971

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 22, 2022

Addresses the (unnecessary) warnings output in #1970 (comment); removes this output,

downsampling query from 1 to 1

when the numbers are equal.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1971 (ac2332c) into latest (2d1fc69) will increase coverage by 7.90%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1971      +/-   ##
==========================================
+ Coverage   83.54%   91.44%   +7.90%     
==========================================
  Files         127       96      -31     
  Lines       14235     9955    -4280     
  Branches     1946     1946              
==========================================
- Hits        11892     9103    -2789     
+ Misses       2070      579    -1491     
  Partials      273      273              
Flag Coverage Δ
python 91.44% <100.00%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 88.37% <100.00%> (ø)
src/core/src/lib.rs
src/core/src/sketch/minhash.rs
src/core/src/index/bigsi.rs
src/core/src/errors.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/ffi/nodegraph.rs
src/core/src/index/search.rs
src/core/src/cmd.rs
src/core/src/storage.rs
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d1fc69...ac2332c. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Apr 22, 2022

ready for review & merge @sourmash-bio/devs - this is an easy one ;)

@ctb ctb merged commit 7433b7f into latest Apr 22, 2022
@ctb ctb deleted the remove/scale_warning branch April 22, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants