Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update release instructions after v4.4.2 #2131

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 20, 2022

This PR:

  • adds pip install build in appropriate places
  • improves instructions for steps that I repeatedly mess up
  • adds a checklist for successful release checks
  • adds draft release note categories / git diff instructions

ref #2129

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #2131 (2b3c4b5) into latest (d8aa9f8) will increase coverage by 7.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2131      +/-   ##
==========================================
+ Coverage   84.31%   91.70%   +7.38%     
==========================================
  Files         130       99      -31     
  Lines       15293    11017    -4276     
  Branches     2167     2167              
==========================================
- Hits        12895    10103    -2792     
+ Misses       2095      611    -1484     
  Partials      303      303              
Flag Coverage Δ
python 91.70% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/cmd.rs
src/core/src/sketch/nodegraph.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/cmd/compute.rs
src/core/src/index/search.rs
src/core/src/index/mod.rs
src/core/src/storage.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/ffi/nodegraph.rs
... and 21 more

@ctb
Copy link
Contributor Author

ctb commented Jul 21, 2022

Ready for review & merge!

@ctb
Copy link
Contributor Author

ctb commented Jul 21, 2022

ready for review & merge @sourmash-bio/devs

@ccbaumler
Copy link
Contributor

The addition of the build module tells the software to look through the pyproject.toml for the specific build artifacts in the file?

@ctb
Copy link
Contributor Author

ctb commented Jul 21, 2022

The addition of the build module tells the software to look through the pyproject.toml for the specific build artifacts in the file?

see https://pypi.org/project/build/ and conversation here: #2112 (comment)

this PR just adds the installation of build to more places where we need it in the release process.

Copy link
Contributor

@ccbaumler ccbaumler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctb
Copy link
Contributor Author

ctb commented Jul 22, 2022

thanks @ccbaumler !

@ctb ctb merged commit 8beaaca into latest Jul 22, 2022
@ctb ctb deleted the update/release_doc branch July 22, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants