-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] revise sourmash tax
user experience and output formats
#2158
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #2158 +/- ##
==========================================
+ Coverage 84.34% 84.43% +0.08%
==========================================
Files 130 130
Lines 15320 15370 +50
Branches 2176 2192 +16
==========================================
+ Hits 12922 12978 +56
+ Misses 2095 2092 -3
+ Partials 303 300 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@bluegenes what do you think of the new human-readable format? I made a new copy of the STAMPS 2022 tutorial and updated the |
column headers would be helpful for printed output! otherwise looking better! |
@bluegenes should we use ANI in the human-readable output? Or add ANI in there? Seems like a good idea... |
At minimum, we should provide it for |
done! example output -
|
sourmash tax
user experience and output formatssourmash tax
user experience and output formats
Ready for review & merge, but no hurry @bluegenes |
should we call this |
Fixed - ready for review & merge @bluegenes ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
human readable format is v helpful and tutorial is great!
some suggested changes, otherwise good
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
@bluegenes re the two remaining comments about classifying at a specific rank, I'm worried I don't understand the code well enough to be sure of what's going on :). I'll take a look in more detail and either resolve the comments or amplify on them with a clearer question before I merge, unless you get a chance to dig into the code and reassure me that I'm not messing anything up here. |
Miscellaneous
sourmash tax
UX tidying, motivated by STAMPS 2022 tutorial.Please see the updated tutorial, added to this PR, here.
This PR:
-F
as a synonym for--output-format
to tax metagenome and tax genome-F human
as a type of output format to tax metagenome and tax genome-F lineage_csv
as output format fortax metagenome
(seetax genome
should directly support lineage CSVs as an output format #2153)Fixes #2153
TODO: