[MRG] fix pickle protocol to properly adjust ksize in __getstate__
#2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2265 +/- ##
==========================================
+ Coverage 84.85% 92.19% +7.34%
==========================================
Files 131 100 -31
Lines 15664 11385 -4279
Branches 2249 2248 -1
==========================================
- Hits 13291 10496 -2795
+ Misses 2082 598 -1484
Partials 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctb
changed the title
ksize in __getstate__ksize in __getstate__
|
@dkoslicki this should be ready for review, if you're up for it! You don't need to verify that it fixes your specific problem in #2262 - just skim through the PR description, and the code changes, and make sure they match, and check that all the github actions succeed(ed)! (You can either formally review, or just say "looks good to me".) |
This was referenced Sep 6, 2022
|
(more generally, any @sourmash-bio/devs are welcome to review - it's a straightforward fix ;) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pickle protocol was broken for non-DNA
MinHashobjects.This PR fixes
MinHash.__getstate__, removes an earlier partial fix inMinHash.to_mutable(), and adds tests at both the object level and the command line level.Fixes #2262
TODO: