Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix links to taxonomy spreadsheets #3119

Merged
merged 1 commit into from Apr 17, 2024
Merged

MRG: fix links to taxonomy spreadsheets #3119

merged 1 commit into from Apr 17, 2024

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 16, 2024

Per #3118, we linked the wrong taxonomy spreadsheet! The one in there is an experimental pangenome one. This PR fixes the links and adds better language.

@ctb
Copy link
Contributor Author

ctb commented Apr 16, 2024

Ready for review @sourmash-bio/devs

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (b441b80) to head (eb26930).

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3119   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         136      136           
  Lines       15809    15809           
  Branches     2713     2713           
=======================================
  Hits        13683    13683           
  Misses       1816     1816           
  Partials      310      310           
Flag Coverage Δ
hypothesis-py 25.36% <ø> (ø)
python 92.32% <ø> (ø)
rust 61.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctb ctb merged commit 08fe5ba into latest Apr 17, 2024
39 of 41 checks passed
@ctb ctb deleted the doc/fix_tax_links branch April 17, 2024 16:10
@ctb
Copy link
Contributor Author

ctb commented Apr 17, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants