Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: allow get/set record.filename #3121

Merged
merged 1 commit into from Apr 20, 2024
Merged

MRG: allow get/set record.filename #3121

merged 1 commit into from Apr 20, 2024

Conversation

bluegenes
Copy link
Contributor

I need to be able to access a record's filename from branchwater to reproduce full gather results. I think this should allow that.

any thoughts/objections, @luizirber? Should I make it get only?

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (08fe5ba) to head (f640c1e).

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3121   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         136      136           
  Lines       15809    15809           
  Branches     2713     2713           
=======================================
  Hits        13683    13683           
  Misses       1816     1816           
  Partials      310      310           
Flag Coverage Δ
hypothesis-py 25.36% <ø> (ø)
python 92.32% <ø> (ø)
rust 61.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bluegenes bluegenes changed the title WIP: allow get/set record.filename MRG: allow get/set record.filename Apr 19, 2024
@bluegenes bluegenes added the rust label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants