-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed when computing hashes now a parameter for all C-level #79
Conversation
restore the pull request
with Git (my own issue, not meaning Git had any... beside making rather hairy to get out trouble).
Current coverage is 76.47% (diff: 75.00%)@@ master #79 diff @@
==========================================
Files 15 17 +2
Lines 2010 2274 +264
Methods 46 48 +2
Messages 0 0
Branches 84 84
==========================================
+ Hits 1496 1739 +243
- Misses 489 510 +21
Partials 25 25
|
constant added (cleaner: the default value can be accessed from the package).
used for a MinHash easily.
instead of an module object.
Is this ready to be reviewed @lgautier ? |
On a quick skim, the only problem I see is that the seed code isn't executed by any tests, nor is the seed saved in any signature/estimator location. I'm happy to address both of those post-merge over in #91, where I'm mucking about with that stuff. |
It is in the sense that pull request is mostly consistent and self-sufficient. The only possible inconsistency is that until the seed is saved into JSON/YAML the consistency between save/load cycles can be broken, also this is not an issue for the casual user since the command line is not letting one play with the seed. I am seeing the following missing:
I'd say review and merge now, than quickly add the save/read seed to/from JSON/YAML ASAP. |
Agreed! I can do the add/save etc in #91. |
LGTM. |
Pickling / unplicking should not be problem since this seed is a default type... but I realizing while writing this that seed is not stored at the Python level. I am happy to give an hand in #91 about this if needed. |
Initial changes to expose hashing seed used at C-level as a parameter (see issue #76).
If deemed reasonable this can be propagated up to command-line.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?