Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix deprecated method warning in lib.rs #391

Merged
merged 1 commit into from
Jul 12, 2024
Merged

MRG: fix deprecated method warning in lib.rs #391

merged 1 commit into from
Jul 12, 2024

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Jul 12, 2024

Fix this warning:

warning: use of deprecated method `pyo3::deprecations::GilRefs::<T>::function_arg`: use `&Bound<'_, T>` instead for this function argument
   --> src/lib.rs:310:45
    |
310 | fn sourmash_plugin_branchwater(_py: Python, m: &PyModule) -> PyResult<(...
    |                                             ^
    |
    = note: `#[warn(deprecated)]` on by default

by swiping code from directsketch.

Note, it looks to me like this will make the pyo3 version bump in #382 work as well 🎉

@ctb
Copy link
Collaborator Author

ctb commented Jul 12, 2024

ready for review & merge @bluegenes !!

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ctb ctb enabled auto-merge (squash) July 12, 2024 14:21
@ctb ctb merged commit 29555ff into main Jul 12, 2024
1 check passed
@ctb ctb deleted the fix_warning branch July 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants